Welcome, Guest. Please login or register.
Did you miss your activation email?
May 16, 2024, 07:16:59 am *

Login with username, password and session length
Pages: [1]
Print
Author Topic: Bards songs and /melody are disconnecting group from server  (Read 4562 times)
shuvel22
Newbie
*
Posts: 4


View Profile
« on: April 22, 2010, 04:31:17 pm »

when im playing my bard (sarinade) lvl 70 and i twist or sing certain songs or i use /melody its disconnecting myself and the entire group from the server were still in the game but everything else disssapears kinda freaky love that bard too please fix hehe... or is it osmething on my end maybe please let me know if theres anything bout to log back in and try just got off work thank you

t
Logged
shuvel22
Newbie
*
Posts: 4


View Profile
« Reply #1 on: April 22, 2010, 04:38:18 pm »

ok seems to be working fine atm dont know i will post again later if something happens thanks anyways
Logged
Trevius
EQEmu Developer
Jr. Member
*****
Posts: 66


View Profile
« Reply #2 on: April 22, 2010, 06:34:59 pm »

Not sure what revision EZ was running on when that problem happened, but if it was rev 1398 or newer, it may have been related to this change:

Quote
   // base fizzlechance is lets say 5%, we can make it lower for AA skills or whatever
   float basefizzle = 10;
   float fizzlechance = basefizzle - specialize + diff / 5.0;

   // always at least 1% chance to fail or 5% to succeed
   fizzlechance = fizzlechance < 1 ? 1 : (fizzlechance > 95 ? 95 : fizzlechance);
   if(IsBardSong(spell_id))
   {
      fizzlechance -= GetAA(aaInternalMetronome) * 1.5f;
   }


   float fizzle_roll = MakeRandomFloat(0, 100);

   mlog(SPELLS__CASTING, "Check Fizzle %s  spell %d  fizzlechance: %0.2f%%   diff: %0.2f  roll: %0.2f", GetName(), spell_id, fizzlechance, diff, fizzle_roll);
   
   if(fizzle_roll > fizzlechance)
      return(true);
   return(false);

Do the bards that cause the crash all have the Internal Metronome AA?  You could probably test with a bard that has it vs one that doesn't to see if one crashes and the other doesn't.  I am not sure, but maybe if they have that AA, and if the roll for fizzlechance starts out as 1, then when it factors in the AA, fizzlechance goes into the negative.  Not sure if that would cause a problem, but maybe.  Even if it isn't the source of the crash, it is till something that may need to be fixed, as I don't think you should ever have a negative fizzle chance Tongue
Logged
Reed
Legend
*******
Posts: 1193



View Profile
« Reply #3 on: April 22, 2010, 07:45:17 pm »

wonder if we could just re-implement #melody again. til the bugs are worked out of /melody
Logged

Hunter
EZ Server GM
Legend
*******
Posts: 8100


EZ Server GM


View Profile
« Reply #4 on: April 22, 2010, 07:51:39 pm »

It a bug in the source code for spells, not just Bards. Secrets fixed it.

Thanks Secrets!
Logged

Hunter - EZ Server GM
Reed
Legend
*******
Posts: 1193



View Profile
« Reply #5 on: April 23, 2010, 01:32:32 pm »

It a bug in the source code for spells, not just Bards. Secrets fixed it.

Thanks Secrets!

Ahh i see i see
Logged

Pages: [1]
Print
Jump to:  

Recent

Stats

Members
  • Total Members: 6126
  • Latest: Maww
Stats
  • Total Posts: 64988
  • Total Topics: 5053
  • Online Today: 221
  • Online Ever: 8678
  • (December 19, 2022, 02:32:09 pm)
Users Online
Users: 1
Guests: 210
Total: 211
TinyPortal v1.0 beta 4 © Bloc