Death Save and Divine Save ie DI and deathpact stuff

[Guest]

Welcome, Guest. Please login or register.
Did you miss your activation email?

1 Hour 1 Day 1 Week 1 Month Forever

Login with username, password and session length

Getting Started

Rules

Character Mover

Optimization Guide

EZ Wiki

EZ Guide

Magelo

Zone List

Spell Recipes

T10.5 Spell Recipes

Crafting Recipes

Donate

EZ Player Discord

[EZ Server Files]

EZ Server Files

EZ Client Downloads

Custom UF MiniMap

Custom UF Inventory

EQEmu Server Status

EQEmulator Home

Allakhazam Home

UFMissingFilesList

TwitchTV

[lerxst2112]

Did I need to replace the spell effect or update it? As stated above, I am using EZ's spell file at the moment.

I don't know what's in the spell file, but if you ran the query posted earlier that gives everyone the AA sets the percent chance to 0.  You'd need a buff on you with effect id 232 that raises the chance to something reasonable.

I posted earlier with a detailed explanation of how it would work with or without the aa.

[hateborne]

I will experiment tonight as I have time. I did scroll back and re-read thread again to make sure I was 100% clear. I did see your explanation lerxst2112 and I will double check. I tried Death Save and Divine Save, but I need to bump up values considerably. Thank you as always

-Hate

[Natedog]

I got up early today, redownloaded source/maps/quests/etc, recompiled, and everything worked. However, I was using the DI and Death Pact from spell file, AAXP on wizard, no luck yet. See below.

http://hateborne.com/ezserver/debug/lolwizard.png

He was hitting slowly for 10k (8x my health bar). Did I need to replace the spell effect or update it? As stated above, I am using EZ's spell file at the moment.

-Hate

It works on EZ currently... just for clerics only .. cast Divine Intervention on your cleric kill the cleric and its around 50% chance to save him

[hateborne]

Ok here goes, lerxst2112 was (unsurprisingly) right. There is a bit of a possible bug.

If Divine Intervention does NOT have a value in the limit field, it does nothing. If ANY numeric value is set, it force casts 4789 (Divine Intervention). The reason it works on the cleric right now is the AAXP has the effect already in it and is combining the aa + spell + item bonuses for DI.

I made a small adjustment to Touch of the Divine, changing it to 50k HP Once value (meaning no charm scaling), removing the Invuln (which is the aggro wipe), and set it to no duration (so it won't pulse purify).

To resolve DI to somewhat normal standards again:

Code:

UPDATE spells_new SET effect_limit_value1 = 4789 WHERE id = 1546;
REPLACE INTO `spells_new` VALUES (4789, 'Touch of the Divine', 'PLAYER_1', '', '', '', 'You have been spared from death!', '', '', 0, 0, 0, 0, 0, 2250, 900000, 0, 0, 0, 10, 0, 0, 0, 0, 50000, 20, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2511, 2045, -1, -1, -1, -1, 1, 1, 1, 1, -1, -1, -1, -1, 100, 100, 100, 100, 100, 100, 100, 100, 100, 100, 100, 100, 0, 1, 0, 0, 254, 10, 10, 10, 79, 291, 254, 254, 254, 254, 254, 254, 6, 25, 4, -1, 0, 0, 255, 254, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 42, 0, 0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 100, 0, 46, 274, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 125, 52, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 100, 0, 999, 3, 6, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 1, 0, 0, 0, 0, 0, -1, 0, 0, 0, 1, 0, 0, 1, 1);

This is a slightly important fix (thanks to Paldail's original work and lerxst2112's constant guidance), so it will go into the fixit thread as well.


-Hate

[Natedog]

So should the spell work WITHOUT the AA? Because it sure isn't working for me =p



I was also wrong... wasn't working at 0% DI for the AA for some reason... hmm


Had to set it to 1 in every rank to get it to work... hmm


But it is also really late.. and im ultra tired.. so I might be doing something wrong lol..

[lerxst2112]

So should the spell work WITHOUT the AA? Because it sure isn't working for me =p

It should work fine without the aa.  The buff would need effect id 232, effect value is the percentage chance to trigger, and effect limit value is the spell to cast in addition to spell 4789.  I suspect you may not have had the effect limit value set which just makes it do nothing.

It seems like it should save you from death and cast spell 4789 even if the buff/aa doesn't have an additional spell defined, but the way it's implemented if there's no additional spell to cast it just doesn't do anything.

[hateborne]

It should work fine without the aa.  The buff would need effect id 232, effect value is the percentage chance to trigger, and effect limit value is the spell to cast in addition to spell 4789.  I suspect you may not have had the effect limit value set which just makes it do nothing.

It seems like it should save you from death and cast spell 4789 even if the buff/aa doesn't have an additional spell defined, but the way it's implemented if there's no additional spell to cast it just doesn't do anything.

As far I can tell, there seems to be a bit of a copy/paste error. Example:

Code:

bool Mob::TryDivineSave() {

	/*
	How Touch of the Divine AA works:
	-Gives chance to avoid death when client is killed.
	-Chance is determined by the AA value. (base1)
	-Spell can be triggered from divine save (base2) in this case a Heal
	Note: Heal value does not and should not increase from more levels of this AA.
	-If chance is met, a heal is done and a divine aura like effect 'Touch of the Divine'
	is applied to the client. Determintal spell effects are removed.
	*/
	sint16 SuccessChance = aabonuses.DivineSaveChance[0] + itembonuses.DivineSaveChance[0] + spellbonuses.DivineSaveChance[0];

	if (SuccessChance)
	{
		if (MakeRandomInt(0, 100) <= SuccessChance)
		{
			int32 HealAmt = 0;
			BuffFadeByEffect(SE_DivineSave);
			//Touch of the Divine=4789, an Invulnerability/HoT/Purify effect hard coded to trigger if spell effect is defined from base2.
			if (aabonuses.DivineSaveChance[1] || itembonuses.DivineSaveChance[1] || spellbonuses.DivineSaveChance[1]) {

				SetHP(1);

				if (aabonuses.DivineSaveChance[1])
					SpellOnTarget(aabonuses.DivineSaveChance[1], this);

				if (itembonuses.DivineSaveChance[1])
					SpellOnTarget(aabonuses.DivineSaveChance[1], this);

				if (spellbonuses.DivineSaveChance[1])
					SpellOnTarget(aabonuses.DivineSaveChance[1], this);

				SpellOnTarget(4789, this);
				SendHPUpdate();
				return true;
			}
		}
	}
	return false;
}

Shouldn't it be:

Code:

bool Mob::TryDivineSave() {

	/*
	How Touch of the Divine AA works:
	-Gives chance to avoid death when client is killed.
	-Chance is determined by the AA value. (base1)
	-Spell can be triggered from divine save (base2) in this case a Heal
	Note: Heal value does not and should not increase from more levels of this AA.
	-If chance is met, a heal is done and a divine aura like effect 'Touch of the Divine'
	is applied to the client. Determintal spell effects are removed.
	*/
	sint16 SuccessChance = aabonuses.DivineSaveChance[0] + itembonuses.DivineSaveChance[0] + spellbonuses.DivineSaveChance[0];

	if (SuccessChance)
	{
		if (MakeRandomInt(0, 100) <= SuccessChance)
		{
			int32 HealAmt = 0;
			BuffFadeByEffect(SE_DivineSave);
			//Touch of the Divine=4789, an Invulnerability/HoT/Purify effect hard coded to trigger if spell effect is defined from base2.
			if (aabonuses.DivineSaveChance[1] || itembonuses.DivineSaveChance[1] || spellbonuses.DivineSaveChance[1]) {

				SetHP(1);

				if (aabonuses.DivineSaveChance[1])
					SpellOnTarget(aabonuses.DivineSaveChance[1], this);

				if (itembonuses.DivineSaveChance[1])
					SpellOnTarget(itembonuses.DivineSaveChance[1], this);

				if (spellbonuses.DivineSaveChance[1])
					SpellOnTarget(spellbonuses.DivineSaveChance[1], this);

				SpellOnTarget(4789, this);
				SendHPUpdate();
				return true;
			}
		}
	}
	return false;
}

Specifically, it has "SpellOnTarget(aabonuses.DivineSaveChance[1], this);" for the AA, Item, and Spell checks.

-Hate

[Natedog]

|| *id* || *name* || *effect_base_value1* || *effect_limit_value1* || *effectid1* ||
|| 1546 || Divine Intervention || 100 || 4789 || 232 ||



-- not working for me thats correct though right?



Procs 100% of the time with the AA set to 1 


Procs never... with just the spell buff ?

[Natedog]

Specifically, it has "SpellOnTarget(aabonuses.DivineSaveChance[1], this);" for the AA, Item, and Spell checks.

-Hate

So each type checks for the AA on the target hmmm.. ?

[hateborne]

So each type checks for the AA on the target hmmm.. ?

Seems to be. My level 1 wizard with 0 AAXP had DI proccing with 100% proc chance, with 50% proc chance, and then with 25% proc chance. The key is to set the limit value to the Touch of the Divine (4789). It seems to default to this cast anyway, but without some legitimate spell ID in the limit value (even though it ignores the spell and STILL goes for Touch of the Divine) then the DI will simply not trigger.

I'm writing a post on EQEMU boards about it now. Hopefully they can get it fixed in a future source.

-Hate

[Natedog]

So each type checks for the AA on the target hmmm.. ?

Seems to be. My level 1 wizard with 0 AAXP had DI proccing with 100% proc chance, with 50% proc chance, and then with 25% proc chance. The key is to set the limit value to the Touch of the Divine (4789). It seems to default to this cast anyway, but without some legitimate spell ID in the limit value (even though it ignores the spell and STILL goes for Touch of the Divine) then the DI will simply not trigger.

I'm writing a post on EQEMU boards about it now. Hopefully they can get it fixed in a future source.

-Hate

It would proc without the AA for me too.. with an OLD OLD OLD Revision of the DB .. with the newest revision though... it doesnt work

[hateborne]

I updated my server to whatever was current last night and it's working for me without the AAXP. Divine Intervention has effectid1 = 232, effect_base_value1 = 50, effect_limit_value1 = 4789.

-Hate


EDIT: When I get home tonight, assuming I have died before then from sleep deprivation, I will check my notes. I don't recall doing anything else, but I've slept ~3h15min last night. So...yeah

[Natedog]

Just updated to Rev2300 -- I will try in a minute heh



Ya.. i can't get it to work the way you are doing it.. I think I'm doing it wrong 

[hateborne]

http://www.eqemulator.org/forums/showthread.php?p=215468#post215468

They acknowledge, fixed, and added to the 2301 revision. Yay


-Hate

[Fugitive]

+1

Advanced search

• Unable to log in by Chieftan [November 23, 2024, 07:04:51 am]
• Everquest Tweaks and Sett... by Pubis [November 18, 2024, 11:18:15 am]
• Broken Stuff Repair Shop ... by Draca [November 12, 2024, 08:47:03 am]
• Update to Halls of Honor by Sarthin [November 10, 2024, 04:57:40 pm]
• Halloween 2024 by clbreastmilk [November 04, 2024, 07:55:17 am]
• Some T12 Questions by Miriya [October 28, 2024, 01:38:59 pm]
• HW 2024 by Raygan [October 21, 2024, 08:03:01 am]
• Ninja Looting by zefirus [October 20, 2024, 04:55:10 pm]
• Official Guild Creation R... by Tylperion [September 15, 2024, 11:54:54 am]
• T11 Feedback Thread by Sarthin [August 28, 2024, 12:45:01 pm]
• What's next for the rest ... by Mixlor [August 27, 2024, 02:01:07 pm]
• Hard Mode NPC by Mixlor [August 06, 2024, 09:37:00 am]
• Looking for some advice (... by Draca [July 31, 2024, 10:55:17 am]
• 4th of July Event by orkiho [July 12, 2024, 07:35:22 pm]
• New Server update causing... by Mixlor [June 02, 2024, 01:01:54 am]
• Memorial Day Event by wachna [May 30, 2024, 01:52:28 pm]
• EZServer Rules by Sarthin [May 30, 2024, 01:10:12 pm]
• Fear Itself, testing week... by torotornot [May 24, 2024, 09:29:42 am]
• Fear Itself, the new Even... by kendiian [April 26, 2024, 11:48:38 pm]
• Recent & Upcoming Changes by Dokplayer2 [April 23, 2024, 10:48:30 pm]
• Issue with my epic by fangzy [April 22, 2024, 07:32:32 pm]
• Few Changes - T11, VP, Gu... by clbreastmilk [April 10, 2024, 11:32:33 am]
• Combine HoH tokens macro.... by Dbeast [April 04, 2024, 05:10:46 pm]
• Warlock self buffs by Fecs [April 04, 2024, 03:56:08 pm]

Members

• Total Members: 6156
• Latest: Rin1

Stats

• Total Posts: 65127
• Total Topics: 5066
• Online Today: 298
• Online Ever: 8678
• (December 19, 2022, 02:32:09 pm)

Users Online

Users: 0
Guests: 249
Total: 249